Skip to content

examples: add the Benchmark tool for TiKV #1331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
LykxSassinator wants to merge 34 commits into
base: master
Choose a base branch
from
Open

examples: add the Benchmark tool for TiKV #1331

LykxSassinator wants to merge 34 commits into from
+2,445 −0

Conversation

@LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented May 9, 2024 •
edited
Loading

Description

This pull request introduces a benchmark tool designed to evaluate the performance of a specific TiKV cluster without the necessity of deploying TiDB.
The motivation of this pr derives from the challenges associated with performance testing TiKV clusters, which typically require deploying one or more TiDB nodes. This process can be time-consuming, and issues related to performance regressions may not be promptly communicated to developers.

Therefore, this pull request offers a simplified implementation of the benchmark tool to address these concerns.

Attention

If you have any other suggestions or proposals regarding this tool, pls comment it. Welcome any advices.

@LykxSassinator
benchtool: basement of benchmarking tool for TiKV.
53d8ecb 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Format and fix errors.
e552ec0 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Polish codes on rawkv part.
70b6d84 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Add timeout.
b312db7 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Polish codes and the output format of RawKV.
f87391b 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Polish output format of RawKV.
14d0c45 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Merge branch 'tikv:master' into bench_tool
ce1410e
@LykxSassinator
Support batch cmds for RawKV workloads.
b0a74a1 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Build basic framework for supporting txn workloads.
d269823 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Polish codes.
ee2e154 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Polish codes.
4241a50 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Fix bugs.
18ce51b 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Fix errs when cleaning up keys.
968b610 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Remove unnecessary arguments.
d1f50b5 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Support pessimistic mode.
aafac36 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Support other RawKV commands expect xxx_ttl commands.
b7b91f0 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Polish codes.
08dcf3f 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Refactor and polish codes.
769d50a 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Add basical framwork for supporting loading manual specifying workloa…
2733847 
…ds pattern.

Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Support pattern workloads.
b63c244 
Signed-off-by: lucasliang <[email protected]>
@ti-chi-bot ti-chi-bot bot added the dco-signoff: yes Indicates the PR's author has signed the dco. label Aug 7, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from lykxsassinator, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 22, 2024
@LykxSassinator
Bugfix.
769f5e5 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Polish codes.
38e82a5 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Add logger.
cc845c4 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Polish codes.
3ae05a4 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Fix the test example.
31e4d8e 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator LykxSassinator marked this pull request as ready for review August 23, 2024 04:21
@ti-chi-bot ti-chi-bot bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2024
@LykxSassinator LykxSassinator changed the title [WIP] Benchmark tool for TiKV examples: add the Benchmark tool for TiKV Aug 23, 2024
@ti-chi-bot ti-chi-bot bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 23, 2024
@cfzjywxk cfzjywxk requested review from ekexium, you06 and zyguan August 26, 2024 02:31
@ekexium
Copy link
Contributor

ekexium commented Aug 26, 2024

Is a go.sum missing? Do we need tests for this tool? We may also need a manual or readme for it.
I think it is not the best option to put the tool in examples, maybe we can have a bin or tools directory for its, or even a standalone repo.

ekexium
ekexium reviewed Aug 26, 2024
View reviewed changes
@LykxSassinator
Copy link
Contributor Author

LykxSassinator commented Aug 26, 2024

Is a go.sum missing? Do we need tests for this tool? We may also need a manual or readme for it. I think it is not the best option to put the tool in examples, maybe we can have a bin or tools directory for its, or even a standalone repo.

FYI, the reason why this tool is set under examples is used to make this tool accessible and easy to use, where the README.md is already specified.

And as for tests, the basic and offline tests have been done for it, which can be reviewed in https://pingcap-cn.feishu.cn/wiki/QtoIwKWqNiiYp7kTujIcjw4RnEh.

Meanwhile, it's acceptable to move this tool into an individual repo if we can make an agreement about this advice.

@LykxSassinator
Polish codes.
07b849e 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Add some extra annotations.
7865a2f 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Polish codes.
6aef6c3 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Add extra annotations for the performance results.
e8d9554 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Fix cf setting bugs.
0fc92e6 
Signed-off-by: lucasliang <[email protected]>
@LykxSassinator
Upload missing prs.
2018333 
Signed-off-by: lucasliang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ekexium ekexium ekexium left review comments

@cfzjywxk cfzjywxk Awaiting requested review from cfzjywxk

@MyonKeminta MyonKeminta Awaiting requested review from MyonKeminta

@zyguan zyguan Awaiting requested review from zyguan

@you06 you06 Awaiting requested review from you06

Assignees

No one assigned

Labels

dco-signoff: yes Indicates the PR's author has signed the dco. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@LykxSassinator @ekexium